From a3a87d27a3de57ab5591d5d2604e6a5c6c806eab Mon Sep 17 00:00:00 2001 From: =?utf8?q?Marek=20Marczykowski-G=C3=B3recki?= Date: Wed, 26 Jul 2017 23:27:14 +0200 Subject: [PATCH] libvchan: Fix cleanup when xc_gntshr_open failed MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit If xc_gntshr_open failed the only thing to cleanup is free allocated memory. So instead of calling libxenvchan_close (which assume valid calculated buffers being mmaped already) free memory and return. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Wei Liu --- tools/libvchan/init.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/libvchan/init.c b/tools/libvchan/init.c index 83e1deec44..e53f3a78d2 100644 --- a/tools/libvchan/init.c +++ b/tools/libvchan/init.c @@ -329,8 +329,10 @@ struct libxenvchan *libxenvchan_server_init(struct xentoollog_logger *logger, } ctrl->gntshr = xengntshr_open(logger, 0); - if (!ctrl->gntshr) - goto out; + if (!ctrl->gntshr) { + free(ctrl); + return 0; + } if (init_evt_srv(ctrl, domain, logger)) goto out; -- 2.30.2